Skip to content

fix: missing components for RSA key pair #59

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

fix: missing components for RSA key pair #59

merged 1 commit into from
May 16, 2025

Conversation

siujamo
Copy link
Contributor

@siujamo siujamo commented May 16, 2025

Updated the regex patterns in the getRawContent method to support both EC and RSA keys for the BEGIN and END markers.

@siujamo siujamo requested review from Copilot and zihluwang May 16, 2025 02:19
@siujamo siujamo self-assigned this May 16, 2025
@siujamo siujamo added the enhancement New feature or request label May 16, 2025
Copilot
Copilot AI reviewed May 16, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the regex patterns in the getRawContent method to support both EC and RSA keys by including an optional group for "RSA ".

  • Updated the regex for "BEGIN" markers.
  • Updated the regex for "END" markers.

@zihluwang zihluwang merged commit be38668 into main May 16, 2025
@siujamo siujamo deleted the fix/component-missing-in-key-loader branch May 16, 2025 06:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@zihluwang zihluwang zihluwang approved these changes

Assignees

@siujamo siujamo

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siujamo @zihluwang