Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature: update UI of creating ontology and edition of it's metadata - part 2 - New Ontology and New Submission UIs #39

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

syphax-bouazzouni
Copy link
Contributor

@syphax-bouazzouni syphax-bouazzouni commented Mar 8, 2025

Require

Context

Original work details ontoportal-lirmm#292
BioPortal context ncbo/bioportal-project#339,

This PR update the UI of creation of an ontology and the new submission, merging the edition of the Ontology and Submission metadata into a unique form.

Changes

Screen.Recording.2025-03-08.at.08.07.59.mov
  • Update new submission form
    • Before
      image

    • After

Screen.Recording.2025-03-08.at.08.18.05.mov
  • Errors handling
    image

  • New ontology header buttons

    • Before
      image

    • After
      image

@jonquet
Copy link

jonquet commented Mar 8, 2025

This code alignment PR is now done directly on OntoPortal upstream code repo? Not the NCBO one ?

@syphax-bouazzouni

This comment was marked as resolved.

@syphax-bouazzouni syphax-bouazzouni changed the title Feature: update UI of creating ontoogy and edition of it's metata - part 2 - New Ontology and New Submission UIs Feature: update UI of creating ontology and edition of it's metata - part 2 - New Ontology and New Submission UIs Mar 8, 2025
@jonquet
Copy link

jonquet commented Mar 8, 2025

Ncbo one sorry.

@syphax-bouazzouni syphax-bouazzouni changed the title Feature: update UI of creating ontology and edition of it's metata - part 2 - New Ontology and New Submission UIs Feature: update UI of creating ontology and edition of it's metadata - part 2 - New Ontology and New Submission UIs Mar 8, 2025
@syphax-bouazzouni
Copy link
Contributor Author

Ncbo one sorry.

All the contributions are done only in the upstream.

@jonquet
Copy link

jonquet commented Mar 8, 2025

Ok. My mistake. No yet fully awake;)

@jvendetti
Copy link
Collaborator

jvendetti commented Mar 13, 2025

@syphax-bouazzouni - I was looking at issue 372 in the BioPortal issue tracker this morning because at least one end user is having a very difficult time editing their ontology due to this issue. I noticed that you've submitted this pull request that indicates that you've fixed this issue. Since the pull request has 144 files modified and encapsulates multiple things, could you at least point more specifically to the code change that mitigates the load time? BioPortal has > 18,000 registered users and all of those account names are loaded into the DOM in the administrators select box as select options when the page is rendered. Our account names aren't in our search index, so I'm not aware of any way currently that we could hook up a select box to a search endpoint. Have you tested the load time of this page against a users list > 18K accounts?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ontology edit page load time has become prohibitively slow
4 participants