Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Multimodality #358

Closed
kevinintel opened this issue Jul 1, 2024 · 10 comments · Fixed by #547
Closed

Multimodality #358

kevinintel opened this issue Jul 1, 2024 · 10 comments · Fixed by #547
Assignees
Milestone

Comments

@kevinintel
Copy link
Contributor

No description provided.

@kevinintel kevinintel added this to OPEA Jul 1, 2024
@kevinintel kevinintel added this to the v0.8 milestone Jul 1, 2024
@tileintel
Copy link
Collaborator

We have submitted the RFC for MM-RAG based Visual QnA application here. I would much appreciate if anyone can review this. Thanks

@tileintel
Copy link
Collaborator

For Multimodal RAG on Videos application, we have created the PR https://github.com/opea-project/GenAIComps/pull/547 for multimodal embedding microservice.
@chensuyue @lvliang-intel @kevinintel: Important note: Could you please review this PR before the PR opea-project/GenAIComps#538.

Thanks

@kevinintel kevinintel linked a pull request Aug 22, 2024 that will close this issue
4 tasks
@github-project-automation github-project-automation bot moved this to Done in OPEA Aug 22, 2024
@kevinintel kevinintel reopened this Aug 22, 2024
@kevinintel
Copy link
Contributor Author

Only comps PR: opea-project/GenAIComps#547

@tileintel
Copy link
Collaborator

Hi @kevinintel. In the development of this issue, it displays a PR #547 from GenAIExamples. This is not related to this issue. Our PR is #547 from GenAIComps (not GenAIExamples). Can you please help to correct it?
Thanks

@kevinintel
Copy link
Contributor Author

Hi tiep,
I can't link to your PR because the catgory is GenAIExamples.
Will you create examples after comps PR merged?

@tileintel
Copy link
Collaborator

Hi tiep, I can't link to your PR because the catgory is GenAIExamples. Will you create examples after comps PR merged?

I see. Yes, we will have 2 to 3 GenAIExamples PR after all comps PR merged.
Thanks for letting me know this.

@tileintel
Copy link
Collaborator

I had to close the PR opea-project/GenAIComps#547, and replace that with the new PR opea-project/GenAIComps#555. This is to resolve required DCO test.

@tileintel
Copy link
Collaborator

@kevinintel We have just created another PR in GenAIComps for multimodal dataprep microservice.
Would you please ask someone to review it?
Also, the previous PR opea-project/GenAIComps#555 hasn't been reviewed yet.

Thanks

@tileintel
Copy link
Collaborator

@kevinintel We have created 2 PRs for 2 usecases of MultimodalRAGQnA application. Can you please update this issue to link with them? Both of the PR are under WIP.
#751
#744
Thanks a lot

@tileintel
Copy link
Collaborator

@kevinintel All PRs for GenAIComps have been merged. The two PRs #751 and #744 have been merged. I think this issue is done. Can you please mark done and close this?

JakubLedworowski pushed a commit to JakubLedworowski/GenAIExamples that referenced this issue Jan 28, 2025
Switch to use latest opea image tag on main branch, and use `manual-freeze-tag`
action to replace with tag version.
Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants