Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: use dto for gethardwareinfo #412

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rjbrache
Copy link
Contributor

No description provided.

@rjbrache rjbrache force-pushed the dtogethardwareinfo2 branch from b7daaf4 to 7e143dd Compare October 18, 2024 23:52
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 97.12919% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.99%. Comparing base (983e14e) to head (b61b5c4).

Files with missing lines Patch % Lines
internal/controller/http/v2/devicemanagement.go 50.00% 5 Missing and 1 partial ⚠️
internal/mocks/wsv1_mocks.go 0.00% 5 Missing ⚠️
internal/usecase/devices/info.go 99.74% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
+ Coverage   69.12%   69.99%   +0.86%     
==========================================
  Files          80       80              
  Lines        9040     9442     +402     
==========================================
+ Hits         6249     6609     +360     
- Misses       2465     2509      +44     
+ Partials      326      324       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjbrache rjbrache force-pushed the dtogethardwareinfo2 branch 11 times, most recently from bba4533 to 85061b6 Compare October 24, 2024 19:19
@rjbrache rjbrache changed the title Dtogethardwareinfo2 feat: use dto for gethardwareinfo Oct 24, 2024
@rjbrache rjbrache force-pushed the dtogethardwareinfo2 branch from 85061b6 to b546cbb Compare October 24, 2024 20:03
@rjbrache rjbrache marked this pull request as ready for review October 24, 2024 20:12
@rjbrache rjbrache requested a review from rsdmike October 24, 2024 20:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants