Skip to content

Commit

Permalink
Fix one flaky test, bump project version
Browse files Browse the repository at this point in the history
  • Loading branch information
fvennetier committed Dec 12, 2019
1 parent cc3c6b7 commit 38df7e6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ if (NOT DEFINED OIOSDS_RELEASE)
set(OIOSDS_RELEASE master)
endif ()
if (NOT DEFINED OIOSDS_PROJECT_VERSION_SHORT)
set(OIOSDS_PROJECT_VERSION_SHORT "6.0")
set(OIOSDS_PROJECT_VERSION_SHORT "6.1")
endif ()

set(OIOSDS_PROJECT_VERSION "${OIOSDS_RELEASE}/${OIOSDS_PROJECT_VERSION_SHORT}")
Expand Down
6 changes: 5 additions & 1 deletion tests/functional/conscience/test_conscience.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@
import logging
import random

from flaky import flaky
from oio.common.json import json
from tests.utils import BaseTestCase
from tests.utils import CODE_SRVTYPE_NOTMANAGED
import simplejson as json


class TestConscienceFunctional(BaseTestCase):
Expand Down Expand Up @@ -264,6 +265,7 @@ def test_lock_survives_conscience_restart(self):
self.assertEqual(1, my_rawx['score'])
self.conscience.unlock_score(one_rawx)

@flaky()
def test_deregister_services(self):
self._flush_cs('echo')
self._reload()
Expand All @@ -272,6 +274,8 @@ def test_deregister_services(self):
expected_services.append(self._srv('echo', ip='127.0.0.2'))
expected_services.append(self._srv('echo', ip='127.0.0.3'))
self._register_srv(expected_services)
# Sometimes the proxy's service registration thread is slow,
# and we get only a partial list, hence the flaky decorator.
services = self._list_srvs('echo')
self.assertListEqual(
sorted([srv['addr'] for srv in expected_services]),
Expand Down

0 comments on commit 38df7e6

Please # to comment.