Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sqliterepo/election: Be more consistent with sharded/multiplied ZK #1696

Merged
merged 3 commits into from
Mar 11, 2019
Merged

sqliterepo/election: Be more consistent with sharded/multiplied ZK #1696

merged 3 commits into from
Mar 11, 2019

Conversation

jfsmig
Copy link
Contributor

@jfsmig jfsmig commented Mar 6, 2019

SUMMARY

Allow to change the value of the value of the managed variable sqliterepo.zk.mux_factor on a running platform. Only works for platforms that never used a positive value prior to this PR, because it was not possible to modify that value without breaking the election FSM.

ISSUE TYPE

enhancement

COMPONENT NAME

sqliterepo

SDS VERSION

openio 4.4.0.0b1.dev80

Copy link
Member

@fvennetier fvennetier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not mention my name in your commit messages.

@codecov-io
Copy link

Codecov Report

Merging #1696 into master will increase coverage by 0.12%.
The diff coverage is 39.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1696      +/-   ##
==========================================
+ Coverage   79.53%   79.65%   +0.12%     
==========================================
  Files         369      369              
  Lines       67978    68351     +373     
  Branches     6846     6880      +34     
==========================================
+ Hits        54061    54436     +375     
+ Misses      13811    13809       -2     
  Partials      106      106
Impacted Files Coverage Δ
sqliterepo/election.c 88.74% <39.14%> (-0.5%) ⬇️
oio/conscience/client.py 79.75% <0%> (-5.96%) ⬇️
oio/account/client.py 81.61% <0%> (-5.74%) ⬇️
tests/functional/cli/account/test_account.py 23.46% <0%> (-1.54%) ⬇️
oio/common/utils.py 66.99% <0%> (-1.3%) ⬇️
oio/blob/indexer.py 70.46% <0%> (-1.19%) ⬇️
oio/directory/meta1.py 88.51% <0%> (-1.14%) ⬇️
oio/common/storage_functions.py 91.43% <0%> (-0.71%) ⬇️
oio/ecd/app.py 65.48% <0%> (-0.59%) ⬇️
sqlx/sqlx_service.c 84.43% <0%> (-0.51%) ⬇️
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d5c42b...6540bee. Read the comment docs.

@jfsmig jfsmig merged commit 98dc3ed into open-io:master Mar 11, 2019
@jfsmig jfsmig deleted the M-review-zk-mux branch March 12, 2019 10:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants