Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CLI: implement 'openio-admin <item_type> check' commands #1697

Merged
merged 8 commits into from
Mar 19, 2019

Conversation

fvennetier
Copy link
Member

@fvennetier fvennetier commented Mar 8, 2019

SUMMARY

Start implementation of new openio-admin commands.
See https://github.com/open-io/oio-product-docs/pull/32.

  • chunk check (output format to be fixed)
  • object check
  • container check
  • account check
  • log to files
  • fix the legacy oio-crawler-integrity
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • CLI
  • Python API
SDS VERSION
openio 4.2.9.dev33
ADDITIONAL INFORMATION

oio-crawler-integrity internals are being refactored in order to be callable by openio-admin commands.

@fvennetier fvennetier force-pushed the admin-cli-step2 branch 3 times, most recently from 195df7c to 89f6506 Compare March 12, 2019 17:56
@codecov-io
Copy link

codecov-io commented Mar 13, 2019

Codecov Report

Merging #1697 into master will increase coverage by 0.01%.
The diff coverage is 67.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1697      +/-   ##
==========================================
+ Coverage   79.56%   79.56%   +0.01%     
==========================================
  Files         370      370              
  Lines       68344    68438      +94     
  Branches     6880     6880              
==========================================
+ Hits        54374    54449      +75     
- Misses      13864    13883      +19     
  Partials      106      106
Impacted Files Coverage Δ
oio/common/http_urllib3.py 86.12% <ø> (ø) ⬆️
tests/unit/api/test_rdir.py 100% <ø> (ø) ⬆️
oio/rdir/client.py 79.94% <ø> (ø) ⬆️
oio/cli/common/clientmanager.py 50.74% <0%> (ø) ⬆️
oio/common/exceptions.py 94.64% <100%> (+0.12%) ⬆️
tests/functional/blob/test_converter.py 98.47% <100%> (+0.94%) ⬆️
oio/common/constants.py 100% <100%> (ø) ⬆️
oio/blob/client.py 90.21% <50%> (-1.39%) ⬇️
oio/common/decorators.py 97.83% <66.67%> (-2.17%) ⬇️
oio/crawler/integrity.py 67.95% <66.67%> (-2.26%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80b678b...0000b79. Read the comment docs.

@fvennetier fvennetier force-pushed the admin-cli-step2 branch 2 times, most recently from 0000b79 to 72e9818 Compare March 14, 2019 11:10
@fvennetier fvennetier changed the title [WIP] CLI: start implementing 'openio-admin <item_type> check' commands CLI: implement 'openio-admin <item_type> check' commands Mar 14, 2019
Support checking multiple object versions (only the latest was checked)
with oio-crawler-integrity and 'openio-admin object check' (and related
commands).

Also allow 'openio-admin <item_type> check' to log to files, as does
oio-crawler-integrity.

Jira: OB-339
Copy link
Contributor

@murlock murlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@AymericDu AymericDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add some tests for these new commands.

@fvennetier fvennetier merged commit 69aa6e6 into open-io:master Mar 19, 2019
@fvennetier fvennetier deleted the admin-cli-step2 branch March 19, 2019 08:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants