CLI: implement 'openio-admin <item_type> locate' commands #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvennetier
force-pushed
the
admin-cli-step3
branch
from
bd4b083 to
10a4cd5
Compare
Codecov Report
@@ Coverage Diff @@
## master #1704 +/- ##
=========================================
Coverage ? 79.58%
=========================================
Files ? 370
Lines ? 68486
Branches ? 6880
=========================================
Hits ? 54500
Misses ? 13880
Partials ? 106Continue to review full report at Codecov.
|
fvennetier
force-pushed
the
admin-cli-step3
branch
from
14eb3da to
6aa513d
Compare
fvennetier
force-pushed
the
admin-cli-step3
branch
2 times, most recently
from
575ebeb to
a0d662f
Compare
fvennetier
force-pushed
the
admin-cli-step3
branch
from
a0d662f to
6a4b3be
Compare
fvennetier
changed the title
AymericDu
reviewed
Mar 25, 2019
AymericDu
reviewed
Mar 26, 2019
| A command to display which service is in charge of hosting an item. | ||
| """ | ||
|
|
||
| columns = ('Type', 'Item', 'Service Id', 'Addr', 'Location', 'Status') |
There was a problem hiding this comment.
We could replace Status with 2 columns (Up and Score)
There was a problem hiding this comment.
What would we display in the Volume column?
I don't like the idea of splitting Status: currently it displays either the status (in the form of a boolean and a score) or the error that occurred during the check. Where would we display the error then?
murlock
approved these changes
Mar 27, 2019
fvennetier
force-pushed
the
admin-cli-step3
branch
from
6a4b3be to
bcb3713
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
SDS VERSION