-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
CLI: list containers from rawx and meta2 #1729
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ea41d3
to
405d7d8
Compare
fvennetier
reviewed
Apr 11, 2019
fvennetier
reviewed
Apr 11, 2019
405d7d8
to
569544b
Compare
murlock
reviewed
Apr 12, 2019
oio/cli/admin/service_list.py
Outdated
reqid = self.app.request_id(self.reqid_prefix) | ||
resp = self.rdir.meta2_index_fetch(meta2, reqid=reqid, **kwargs) | ||
if resp.get('truncated'): | ||
self.log.info( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be self.logger
IMO
oio/cli/admin/service_list.py
Outdated
if resp.get('truncated'): | ||
self.log.info( | ||
'Object listing has been truncated, next marker: %s', | ||
resp.get('next_marker')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest.get('next_marker')
is None
when I test on my side
35f1142
to
667e451
Compare
fvennetier
reviewed
Apr 16, 2019
- fix help - translate CIDs on-the-fly - allow to show untranslated CIDs (faster)
667e451
to
e53dfc2
Compare
fvennetier
approved these changes
Apr 17, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Build a list of containers:
Jira: R1904-21
ISSUE TYPE
COMPONENT NAME
SDS VERSION