Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tests: implement a facility to wait for a specific event #1741

Merged
merged 2 commits into from
Apr 19, 2019

Conversation

fvennetier
Copy link
Member

SUMMARY

Implement a facility to wait for a specific event. The event can be specified by type and/or request ID. The purpose of this feature is to speedup tests which previously used time.sleep() to ensure an event had been handled.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • tests
SDS VERSION
openio 4.4.3.dev1

@fvennetier fvennetier requested review from murlock and AymericDu April 17, 2019 17:07
Event can be specified by type and/or request ID.
@fvennetier fvennetier force-pushed the improve-tests-using-events branch from 1b462a3 to 05b9410 Compare April 18, 2019 07:17
@codecov-io
Copy link

codecov-io commented Apr 18, 2019

Codecov Report

Merging #1741 into 4.4.x will increase coverage by 0.44%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            4.4.x    #1741      +/-   ##
==========================================
+ Coverage   79.36%   79.79%   +0.44%     
==========================================
  Files         355      371      +16     
  Lines       67086    68728    +1642     
  Branches     6919     6954      +35     
==========================================
+ Hits        53233    54837    +1604     
+ Misses      13853    13787      -66     
- Partials        0      104     +104
Impacted Files Coverage Δ
...sts/functional/content/test_content_perfectible.py 82.49% <100%> (ø) ⬆️
tests/functional/blob/test_blob.py 99.29% <100%> (+0.19%) ⬆️
tests/utils.py 92.03% <100%> (+4.36%) ⬆️
tests/functional/api/test_objectstorage.py 97.22% <100%> (-0.08%) ⬇️
oio/ecd/app.py 60.12% <0%> (-6.54%) ⬇️
oio/account/client.py 81.61% <0%> (-5.74%) ⬇️
meta2v2/meta2_bean_utils.c 59% <0%> (-1%) ⬇️
oio/api/io.py 85.87% <0%> (-0.53%) ⬇️
oio/rdir/client.py 80.49% <0%> (-0.34%) ⬇️
metautils/lib/comm_converter.c 72.78% <0%> (-0.26%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81b44d2...3821c82. Read the comment docs.

@fvennetier fvennetier requested a review from kamel-rahim April 18, 2019 15:11
@fvennetier fvennetier force-pushed the improve-tests-using-events branch from 0832692 to 3821c82 Compare April 19, 2019 08:44
@fvennetier fvennetier merged commit 7933f1a into open-io:4.4.x Apr 19, 2019
@fvennetier fvennetier deleted the improve-tests-using-events branch April 19, 2019 12:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants