-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
rawx: Performance improvements #1746
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be rebased on the master branch since it is a rather big change and requires a new dependency. |
Raw JSON generation is much lighter than the reflection-based implementation.
... as we already do for other oio-sds services
Less redundancy with an idiomatic switch/case statement
Now uses sendfile() in downloads, every time it is possible.
Add error logs for few error code path
Codecov Report
@@ Coverage Diff @@
## master #1746 +/- ##
=========================================
+ Coverage 79.12% 79.5% +0.39%
=========================================
Files 361 377 +16
Lines 68034 69815 +1781
Branches 6885 6920 +35
=========================================
+ Hits 53822 55501 +1679
Misses 14212 14212
- Partials 0 102 +102
Continue to review full report at Codecov.
|
murlock
approved these changes
Apr 24, 2019
AymericDu
approved these changes
Apr 24, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
TL;DR: the golang rawx is now much faster but requires a new dependency on
golang.org/x/sys/unix
sendfile()
functionKnown TODO: make the golang rawx multi-tube.
ISSUE TYPE
enhancement
COMPONENT NAME
rawx
SDS VERSION
openio 4.4.3.dev6