Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improve Admin CLI #1755

Merged
merged 10 commits into from
May 7, 2019
Merged

Improve Admin CLI #1755

merged 10 commits into from
May 7, 2019

Conversation

AymericDu
Copy link
Member

@AymericDu AymericDu commented Apr 30, 2019

SUMMARY
  • Limit speed of distributed dispatcher
  • Use the same column Errors to display the errors
  • Fail the command if there is at least one error
  • Set the default verbose level to INFO
  • Use common mixin
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • Python API
  • Admin CLI
SDS VERSION
openio 5.0.0.0a2.dev20

@AymericDu AymericDu force-pushed the improve-admin-cli branch 5 times, most recently from e71a43c to 5398357 Compare May 3, 2019 09:53
@AymericDu AymericDu changed the title [WIP] Improve Admin CLI Improve Admin CLI May 3, 2019
@AymericDu AymericDu requested review from fvennetier, murlock and kamel-rahim and removed request for fvennetier and murlock May 3, 2019 09:54
@AymericDu AymericDu force-pushed the improve-admin-cli branch 3 times, most recently from 5e071ef to 740c3aa Compare May 6, 2019 12:48
yield res

def check_chunks(self, service, chunks, checker):
url = self._ensure_http_prefix(service)
url = 'http://' + service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it compatible with Service ID ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AymericDu AymericDu force-pushed the improve-admin-cli branch from 740c3aa to 8619a5b Compare May 6, 2019 14:34
@codecov-io
Copy link

codecov-io commented May 6, 2019

Codecov Report

Merging #1755 into master will decrease coverage by 0.07%.
The diff coverage is 39.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1755      +/-   ##
==========================================
- Coverage   79.21%   79.15%   -0.06%     
==========================================
  Files         379      379              
  Lines       69886    69981      +95     
  Branches     6876     6876              
==========================================
+ Hits        55355    55387      +32     
- Misses      14330    14393      +63     
  Partials      201      201
Impacted Files Coverage Δ
oio/crawler/integrity.py 69.81% <ø> (+1.23%) ⬆️
tests/functional/cli/admin/test_service_decache.py 85.42% <0%> (+4.17%) ⬆️
oio/common/tool.py 24.3% <0%> (-1.19%) ⬇️
oio/cli/common/shell.py 80.44% <100%> (+3.43%) ⬆️
oio/cli/admin/__init__.py 84.22% <100%> (-5.78%) ⬇️
oio/cli/admin/item_check.py 33.34% <28%> (+3.08%) ⬆️
oio/cli/admin/common.py 28.58% <31.65%> (+1.65%) ⬆️
tests/functional/cli/admin/test_item_move.py 29.68% <33.34%> (+0.33%) ⬆️
oio/cli/admin/service_check.py 70.95% <65.63%> (-1.11%) ⬇️
oio/common/wsgi.py 43.21% <0%> (-4.93%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26e08f6...8619a5b. Read the comment docs.

@AymericDu AymericDu merged commit 482e114 into open-io:master May 7, 2019
@AymericDu AymericDu deleted the improve-admin-cli branch May 7, 2019 12:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants