Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Few fixes around x-oio-req-id #1767

Merged
merged 2 commits into from
May 13, 2019

Conversation

murlock
Copy link
Contributor

@murlock murlock commented May 9, 2019

SUMMARY

Our Python API was duplicating x-oio-req-id header when sending a request
The GO Rawx was not limited length of req-id to 63 chars and response was replying with deprecated x-trans-id

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

oio
rawx

SDS VERSION
5.0.0.0a2.dev36

murlock added 2 commits May 9, 2019 10:28
Also use x-oio-red-id in reply instead of deprecated x-trans-id
@murlock murlock requested review from AymericDu and kamel-rahim May 9, 2019 10:01
@codecov-io
Copy link

Codecov Report

Merging #1767 into master will decrease coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1767      +/-   ##
==========================================
- Coverage   79.21%   79.15%   -0.06%     
==========================================
  Files         379      379              
  Lines       69981    69983       +2     
  Branches     6876     6877       +1     
==========================================
- Hits        55431    55390      -41     
- Misses      14349    14389      +40     
- Partials      201      204       +3
Impacted Files Coverage Δ
oio/api/base.py 87.76% <100%> (-2.04%) ⬇️
rawx/rawx.go 82.15% <33.34%> (-3.04%) ⬇️
tests/unit/api/test_container_client.py 92.86% <0%> (-7.14%) ⬇️
oio/ecd/app.py 60.12% <0%> (-6.54%) ⬇️
metautils/lib/volume_lock.c 70% <0%> (-5%) ⬇️
tests/functional/cli/admin/test_service_decache.py 81.25% <0%> (-4.16%) ⬇️
rawx-apache2/src/rawx_event.c 80.77% <0%> (-3.84%) ⬇️
oio/crawler/storage_tierer.py 57.8% <0%> (-2.75%) ⬇️
metautils/lib/rrd.c 74.36% <0%> (-2.56%) ⬇️
oio/blob/client.py 91.16% <0%> (-2.04%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482e114...6b7a920. Read the comment docs.

@fvennetier fvennetier merged commit 5380fc5 into open-io:master May 13, 2019
@murlock murlock deleted the M-api-duplicate-req-id branch January 9, 2020 07:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants