Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

crawler: provide informations from rdir to integrity crawler #1768

Merged

Conversation

murlock
Copy link
Contributor

@murlock murlock commented May 9, 2019

SUMMARY

When openio-admin rawx check finds a chunk indexed in rdir but missing from the rawx service, the process stops.

This commit enriches the output with information retrieved from rdir.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

OIO

SDS VERSION
openio 5.0.0.0b0

When `openio-admin rawx check` found an indexed chunk from rdir
but missing on rawx, the CLI stops.

This commit enrich crawler checker with fields retrieved from rdir.
@murlock murlock requested review from fvennetier and AymericDu May 9, 2019 13:42
@murlock
Copy link
Contributor Author

murlock commented May 9, 2019

Please note that openio-admin chunk check is not fixed with this PR:
we should add a step to search on rdir the cid and contentid`

Copy link
Member

@AymericDu AymericDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When openio-admin rawx check will be fixed, we should add some tests.

@codecov-io
Copy link

Codecov Report

Merging #1768 into master will decrease coverage by 0.09%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1768      +/-   ##
==========================================
- Coverage   79.21%   79.13%   -0.08%     
==========================================
  Files         379      379              
  Lines       69981    69986       +5     
  Branches     6876     6876              
==========================================
- Hits        55431    55376      -55     
- Misses      14349    14408      +59     
- Partials      201      202       +1
Impacted Files Coverage Δ
oio/cli/admin/service_check.py 71.51% <ø> (ø) ⬆️
oio/crawler/integrity.py 68.2% <20%> (-1.8%) ⬇️
meta0v2/meta0_remote.c 74.29% <0%> (-8.57%) ⬇️
oio/common/wsgi.py 43.21% <0%> (-4.93%) ⬇️
rawx-apache2/src/rawx_event.c 80.77% <0%> (-3.84%) ⬇️
meta1v2/meta1_prefixes.c 75.78% <0%> (-3.09%) ⬇️
meta2v2/meta2_filters_action_container.c 59.73% <0%> (-2.77%) ⬇️
metautils/lib/rrd.c 74.36% <0%> (-2.56%) ⬇️
oio/blob/client.py 91.16% <0%> (-2.04%) ⬇️
server/slab.c 83.77% <0%> (-1.94%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 482e114...3ebd6a3. Read the comment docs.

@fvennetier fvennetier merged commit dcad6ec into open-io:master May 13, 2019
@murlock murlock deleted the M-integrity-missing-indexed-chunk branch January 9, 2020 07:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants