Python API: recompute deadline after data upload success #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvennetier
force-pushed
the
recompute-deadline
branch
from
72d1ec5 to
046e033
Compare
fvennetier
force-pushed
the
recompute-deadline
branch
from
046e033 to
44f44e8
Compare
AymericDu
approved these changes
May 14, 2019
Codecov Report
@@ Coverage Diff @@
## master #1771 +/- ##
==========================================
- Coverage 79.19% 79.19% -<.01%
==========================================
Files 379 379
Lines 70001 70023 +22
Branches 6878 6879 +1
==========================================
+ Hits 55428 55445 +17
- Misses 14370 14376 +6
+ Partials 203 202 -1
Continue to review full report at Codecov.
|
kamel-rahim
approved these changes
May 15, 2019
fvennetier
force-pushed
the
recompute-deadline
branch
from
44f44e8 to
3c4f13c
Compare
At some point in the upload process, we know that the metadata server is fine (it provided us with chunk addresses) and the client is still listening (he just uploaded all data). It seems a good idea to postpone the deadline.
fvennetier
force-pushed
the
recompute-deadline
branch
from
3c4f13c to
a645d04
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
At some point in the upload process, we know that the metadata server is fine (it provided us with chunk addresses) and the client is still listening (he just uploaded all data). It seems a good idea to postpone the deadline (because it is computed from the client-provided timeout).
ISSUE TYPE
COMPONENT NAME
SDS VERSION
ADDITIONAL INFORMATION
This modification will allow slow uploads to take longer than
read_timeout, provided the client is still sending data from time to time.