Do not read conscience persistence file if a hub is running

[fvennetier]

SUMMARY

If a hub is running, reinjecting the old conscience state can have nasty effects, like respawning service entries that have been explicitly flushed when the local conscience service was down.

Also remove an sqliterepo parameter that is no more used.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

• Consicence
• sqliterepo

SDS VERSION

openio 4.4.3.dev14

[fvennetier]

This needs a little more work to either:

• adapt the failing test to retry a few seconds later;
• make the conscience refuse to serve requests until it has fetched a list of services from the other conscience instances.

[codecov-io]

Codecov Report

Merging #1778 into 4.4.x will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           4.4.x    #1778      +/-   ##
=========================================
+ Coverage   79.9%   79.94%   +0.04%     
=========================================
  Files        371      371              
  Lines      68836    68842       +6     
  Branches    6961     6963       +2     
=========================================
+ Hits       54996    55026      +30     
+ Misses     13736    13712      -24     
  Partials     104      104

Impacted Files	Coverage Δ
sqliterepo/election.c	89.97% <ø> (ø)	⬇️
cluster/module/server.c	79.98% <100%> (+0.25%)	⬆️
oio/blob/indexer.py	67.43% <0%> (-1.51%)	⬇️
proxy/metacd_http.c	89.93% <0%> (-1.1%)	⬇️
meta1v2/meta1_gridd_dispatcher.c	68.35% <0%> (-0.91%)	⬇️
sqliterepo/gridd_client_pool.c	81.58% <0%> (-0.87%)	⬇️
metautils/lib/gridd_client.c	75.5% <0%> (-0.49%)	⬇️
proxy/cs_actions.c	89.38% <0%> (-0.36%)	⬇️
server/transport_gridd.c	77.92% <0%> (-0.2%)	⬇️
sqliterepo/replication_dispatcher.c	64.2% <0%> (-0.15%)	⬇️
... and 28 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3efd4c2...5ade0c2. Read the comment docs.