Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

meta1: resolve account and cname only when asked #1786

Merged

Conversation

fvennetier
Copy link
Member

SUMMARY

This is to avoid problems during migrations from pre 4.4.0 versions.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • oioproxy
  • meta1
SDS VERSION
openio 4.4.4.dev10

Copy link
Contributor

@murlock murlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

This is to avoid problems during migrations from pre 4.4.0 versions.
@fvennetier fvennetier force-pushed the meta1-resolve-acct-cname-only-when-asked branch from c1adf74 to bc8ca2e Compare May 23, 2019 08:43
@codecov-io
Copy link

Codecov Report

Merging #1786 into 4.4.x will decrease coverage by 0.55%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           4.4.x    #1786      +/-   ##
=========================================
- Coverage   79.9%   79.36%   -0.54%     
=========================================
  Files        371      371              
  Lines      68836    70483    +1647     
  Branches    6961     7287     +326     
=========================================
+ Hits       54996    55930     +934     
- Misses     13736    14449     +713     
  Partials     104      104
Impacted Files Coverage Δ
meta1v2/meta1_gridd_dispatcher.c 69.69% <100%> (+0.42%) ⬆️
meta1v2/meta1_remote.c 78.67% <100%> (+0.15%) ⬆️
tests/unit/test_meta1_backend.c 99.43% <100%> (ø) ⬆️
meta1v2/meta1_backend_services.c 56.02% <100%> (+0.07%) ⬆️
sqliterepo/election.c 69.09% <0%> (-20.88%) ⬇️
oio/cli/common/shell.py 74.68% <0%> (-3.1%) ⬇️
oio/blob/indexer.py 67.43% <0%> (-1.51%) ⬇️
oio/common/wsgi.py 43.21% <0%> (-1.23%) ⬇️
oio/api/object_storage.py 81.32% <0%> (-1.19%) ⬇️
sqliterepo/gridd_client_pool.c 81.58% <0%> (-0.87%) ⬇️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3efd4c2...bc8ca2e. Read the comment docs.

@fvennetier fvennetier merged commit bd7d402 into open-io:4.4.x May 23, 2019
@fvennetier fvennetier deleted the meta1-resolve-acct-cname-only-when-asked branch May 23, 2019 12:26
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants