sqliterepo: prevent unneeded loop at election start #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murlock
reviewed
Jun 24, 2019
fvennetier
force-pushed
the
election-start-without-database
branch
from
bab3fdc to
e3eaf64
Compare
AymericDu
approved these changes
Jun 25, 2019
murlock
approved these changes
Jun 25, 2019
kamel-rahim
approved these changes
Jun 25, 2019
fvennetier
force-pushed
the
election-start-without-database
branch
from
9d4366c to
4d1b601
Compare
If the database has just been created, the cached admin table does not contain new entries. These entries may be required by the change callback, and thus we need to reload the whole admin table before calling it. Jira: OS-107
External DB_VERS requests used to create the database, but internal ones did not. This resulted in a meta2 service never being elected master during M2_CREATE requests. Jira: OS-411
fvennetier
force-pushed
the
election-start-without-database
branch
from
08a4a5e to
7db4826
Compare
|
The original patch did not work as expected. Meta2 rebuilders showed too many errors. I had to rework the pull request completely. |
murlock
approved these changes
Jun 27, 2019
AymericDu
approved these changes
Jun 28, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
External DB_VERS requests used to create the database, but internal ones did not. This resulted in a meta2 service never being elected master during M2_CREATE requests. Now that the internal requests also create the database, a simple benchmark shows a 3x performance increase (3x more meta2 databases created per second).
Jira: OS-411
ISSUE TYPE
COMPONENT NAME
SDS VERSION