-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Python API: Fix ratelimit #1924
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before: ``` loop 1: run_time = now loop 1: loop 1: run_time' = run_time + time_per_request loop 1: -> run_time' = now + time_per_request loop 2: now' >= now loop 2: loop 2: To verify loop 2: run_time' - now' > time_per_request loop 2: -> now + time_per_request - now' > time_per_request loop 2: -> now - now' > 0 loop 2: -> now > now' loop 2: => impossible: now' >= now loop 2: => never sleep loop 2: loop 2: run_time'' = run_time' + time_per_request loop 2: -> run_time'' = now + time_per_request + time_per_request loop 2: -> run_time'' = now + (2 * time_per_request) loop 3: now'' >= now' loop 3: -> now'' >= now' >= now loop 3: loop 3: To verify loop 3: run_time'' - now'' > time_per_request loop 3: -> now + (2 * time_per_request) - now'' > time_per_request loop 3: -> now + time_per_request - now'' > 0 loop 3: -> now + time_per_request > now'' loop 3: => possible: now'' >= now' >= now loop 3: => maybe sleep loop 3: loop 3: run_time''' = run_time'' + time_per_request loop 3: -> run_time''' = now + (2 * time_per_request) + time_per_request loop 3: -> run_time''' = now + (3 * time_per_request) loop 4: now''' >= now'' + (run_time'' - now'') # now'' + "sleep time" loop 4: -> now''' >= run_time'' loop 4: loop 4: To verify loop 4: run_time''' - now''' > time_per_request loop 4: -> run_time'' + time_per_request - now''' > time_per_request loop 4: -> run_time'' - now''' > 0 (hors now''' >= run_time'') loop 4: -> run_time'' > now''' loop 4: => impossible: now''' >= run_time'' loop 4: => never sleep loop 4: loop 4: run_time'''' = run_time''' + time_per_request etc. ``` ``` >>> from oio.common.green import ratelimit, time >>> items_run_time = 0 >>> while True: ... items_run_time = ratelimit(items_run_time, 1) ... print(time.time()) ... 1573838622.18 1573838622.18 1573838624.18 1573838624.18 1573838626.18 1573838626.18 1573838628.18 1573838628.18 ``` After: ``` loop 1: run_time = now loop 1: loop 1: run_time' = run_time + time_per_request loop 1: -> run_time' = now + time_per_request loop 2: now' >= now loop 2: loop 2: To verify loop 2: run_time' - now' > 0 loop 2: -> now + time_per_request - now' > 0 loop 2: -> now + time_per_request > now' loop 2: => possible: now' >= now loop 2: => maybe sleep loop 2: loop 2: run_time'' = run_time' + time_per_request loop 2: -> run_time'' = now + time_per_request + time_per_request loop 2: -> run_time'' = now + (2 * time_per_request) loop 3: now'' >= now' + (run_time' - now') # now' + "sleep time" loop 3: -> now'' >= run_time' loop 3: -> now'' >= now + time_per_request loop 3: loop 3: To verify loop 3: run_time'' - now'' > 0 loop 3: -> now + (2 * time_per_request) > now'' loop 3: => possible: now'' >= now + time_per_request loop 3: => maybe sleep loop 3: loop 3: run_time''' = run_time'' + time_per_request loop 3: -> run_time''' = now + (2 * time_per_request) + time_per_request loop 3: -> run_time''' = now + (3 * time_per_request) loop 4: now''' >= now'' + (run_time'' - now'') # now'' + "sleep time" loop 4: -> now''' >= run_time'' loop 4: -> now''' >= now + (2 * time_per_request) loop 4: loop 4: To verify loop 4: run_time''' - now''' > 0 loop 4: -> now + (3 * time_per_request) > now''' loop 4: => possible: now''' >= now + (2 * time_per_request) loop 4: => maybe sleep loop 4: loop 4: run_time'''' = run_time''' + time_per_request etc. ``` ``` >>> from oio.common.green import ratelimit, time >>> items_run_time = 0 >>> while True: ... items_run_time = ratelimit(items_run_time, 1) ... print(time.time()) ... 1573838486.79 1573838487.8 1573838488.8 1573838489.8 1573838490.8 1573838491.8 1573838492.8 1573838493.8 ```
Codecov Report
@@ Coverage Diff @@
## 4.x #1924 +/- ##
==========================================
- Coverage 80.63% 80.61% -0.02%
==========================================
Files 374 375 +1
Lines 70448 70492 +44
Branches 7020 7023 +3
==========================================
+ Hits 56801 56818 +17
- Misses 13525 13540 +15
- Partials 122 134 +12
Continue to review full report at Codecov.
|
fvennetier
approved these changes
Nov 18, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix ratelimit
ISSUE TYPE
COMPONENT NAME
SDS VERSION
ADDITIONAL INFORMATION
Before:
After: