Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

event-agent: Encode without whitespace when forwarding an event #1965

Conversation

AymericDu
Copy link
Member

SUMMARY

Encode without whitespace when notifying event to make sure not to exceed the maximum size of the event (default: 65535).

Jira: OS-472

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • event-agent
SDS VERSION
openio 4.8.2.dev13

@fvennetier fvennetier changed the title event-agent: Encode without whitespace when notifying event event-agent: Encode without whitespace when forwarding an event Jan 8, 2020
@codecov-io
Copy link

Codecov Report

Merging #1965 into 4.x will increase coverage by 3.16%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              4.x    #1965      +/-   ##
==========================================
+ Coverage   77.52%   80.68%   +3.16%     
==========================================
  Files         324      375      +51     
  Lines       64637    70517    +5880     
  Branches     6774     7027     +253     
==========================================
+ Hits        50103    56888    +6785     
+ Misses      14533    13507    -1026     
- Partials        1      122     +121
Impacted Files Coverage Δ
oio/event/filters/notify.py 79.32% <100%> (ø) ⬆️
metautils/lib/volume_lock.c 70% <0%> (-5%) ⬇️
tests/functional/audit/test_audit_storage.py 82.93% <0%> (-4.87%) ⬇️
meta1v2/meta1_server.c 69.92% <0%> (-1.62%) ⬇️
oio/event/beanstalk.py 63.69% <0%> (-0.58%) ⬇️
oio/api/io.py 88.8% <0%> (-0.21%) ⬇️
rdir/rdir.c 85.48% <0%> (-0.08%) ⬇️
core/proxy.c 82.24% <0%> (ø) ⬆️
oio/rdir/client.py 83.55% <0%> (ø) ⬆️
server/slab.h 100% <0%> (ø) ⬆️
... and 140 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6d59e8...a7c88ed. Read the comment docs.

@fvennetier fvennetier merged commit c120dc9 into open-io:4.x Jan 8, 2020
@AymericDu AymericDu deleted the event-agent-encode-without-whitespace-when-notifying-event branch January 13, 2020 09:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants