CLI: check peer count before actually rebalancing meta1 #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AymericDu
approved these changes
Jan 16, 2020
| read_timeout=parsed_args.meta0_timeout) | ||
| self.log.info("Moved %s", moved) | ||
| else: | ||
| self.log.warn("Nothing done due to errors") |
There was a problem hiding this comment.
We should also add self.success = False.
Also implement a new 'openio directory check' command, checking each reference prefix is managed by the right number of meta1 services. This complements 'openio-admin directory check' (which does not check this number). Jira: OS-470
fvennetier
force-pushed
the
check-peer-count-before-rebalance
branch
from
5781188 to
c1e7b0a
Compare
vdombrovski
approved these changes
Jan 16, 2020
Codecov Report
@@ Coverage Diff @@
## 5.x #1972 +/- ##
=========================================
- Coverage 78.7% 78.65% -0.04%
=========================================
Files 377 377
Lines 72279 72279
Branches 7025 7022 -3
=========================================
- Hits 56877 56841 -36
- Misses 15294 15327 +33
- Partials 108 111 +3
Continue to review full report at Codecov.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
During a rebalance operation, check each reference prefix is managed by the right number of meta1 services.
Also implement a new 'openio directory check' command, checking each reference prefix is managed by the right number of meta1 services. This complements 'openio-admin directory check' (which does not check this number).
Jira: OS-470
ISSUE TYPE
COMPONENT NAME
SDS VERSION
ADDITIONAL INFORMATION