Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Admin CLI improvements #1994

Merged
merged 1 commit into from
Feb 28, 2020
Merged

Conversation

fvennetier
Copy link
Member

SUMMARY
  • Make variable names intelligible (no more one letter variables).
  • Replace some assertions by exceptions, with messages telling what is wrong.

Jira: OS-491

ISSUE TYPE
  • Feature Pull Request
  • Bugfix Pull Request
COMPONENT NAME
  • CLI
SDS VERSION
openio 5.3.0.0b1.dev14

@codecov-io
Copy link

Codecov Report

Merging #1994 into 5.x will increase coverage by 16.87%.
The diff coverage is 64.52%.

Impacted file tree graph

@@             Coverage Diff             @@
##              5.x    #1994       +/-   ##
===========================================
+ Coverage   62.36%   79.23%   +16.87%     
===========================================
  Files         265      391      +126     
  Lines       54754    73980    +19226     
  Branches     6876     7027      +151     
===========================================
+ Hits        34144    58608    +24464     
+ Misses      20322    15133     -5189     
+ Partials      288      239       -49
Impacted Files Coverage Δ
oio/cli/admin/service_check.py 72.05% <64.52%> (ø)
meta2v2/meta2_dedup_utils.c 18.56% <0%> (ø) ⬆️
tests/unit/api/test_ec.py 86.23% <0%> (ø) ⬆️
rawx-apache2/src/rawx_bucket.c 0% <0%> (ø) ⬆️
tests/unit/common/test_fullpath.py 100% <0%> (ø) ⬆️
sqlx/sqlx_server.c 78.95% <0%> (ø) ⬆️
tests/unit/api/test_objectstorage.py 98.33% <0%> (ø) ⬆️
oio/common/constants.py 100% <0%> (ø) ⬆️
tests/unit/common/test_exceptions.py 100% <0%> (ø) ⬆️
rawx-lib/src/compression.c 0% <0%> (ø) ⬆️
... and 340 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2377a15...0705fc6. Read the comment docs.

@fvennetier fvennetier merged commit f32182a into open-io:5.x Feb 28, 2020
@fvennetier fvennetier deleted the admin-cli-improvements branch February 28, 2020 10:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants