Respect minimum distance when rebalancing meta1 databases #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murlock
reviewed
Mar 23, 2020
oio/directory/meta0.py
Outdated
|
|
||
| if len(available_svcs_by_site) < self.replicas: | ||
| raise ValueError( | ||
| "Less than %s services have a positive score " |
There was a problem hiding this comment.
You should include len(available_svcs_by_site) in error message
There was a problem hiding this comment.
Condition and message seems incoherent:
site is first tag of loc so available_svcs_by_site will contains a dict of number of service (with score) per site.
I suppose error message should be Less than %s sites have a positve score ?
| for svc_addr in svc_addrs] | ||
| svcs.sort(key=(lambda svc: svc['upper_limit'] | ||
| - len(self.get_managed_bases(svc)))) | ||
| _decommission(svcs[0], [base]) |
There was a problem hiding this comment.
How the rebalance will react if an Exception is raised ? do we have to fix the issue and rerun the rebalance ?
There was a problem hiding this comment.
Yes, we need to fix the issue and rerun the rebalance.
fvennetier
reviewed
Mar 23, 2020
AymericDu
force-pushed
the
respect-min-dist-when-rebalancing-meta1-databases
branch
from
b76e4af to
28ee7dd
Compare
AymericDu
force-pushed
the
respect-min-dist-when-rebalancing-meta1-databases
branch
from
28ee7dd to
b712cce
Compare
fvennetier
approved these changes
Mar 27, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Respect minimum distance when rebalancing meta1 databases
ISSUE TYPE
COMPONENT NAME
SDS VERSION