Allow to set incident date when rebuilding #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvennetier
approved these changes
Mar 30, 2020
murlock
reviewed
Mar 30, 2020
oio/cli/admin/xcute/rawx.py
Outdated
| '(see "openio volume admin show").') | ||
| parser.add_argument( | ||
| '--set-specific-incident-date', type=int, | ||
| help='Set a specific incident date to rebuild from this date. ' |
There was a problem hiding this comment.
Please add (seconds since Epoch)
murlock
approved these changes
Mar 30, 2020
AymericDu
force-pushed
the
xcute-allow-to-set-incident-date-when-rebuilding
branch
from
0343824 to
6f8690a
Compare
loamhoof
reviewed
Mar 31, 2020
oio/xcute/jobs/blob_rebuilder.py
Outdated
| cls.DEFAULT_DECLARE_INCIDENT_DATE): | ||
| set_incident_date = int(time.time()) | ||
| if set_incident_date is not None: | ||
| sanitized_job_params['set_incident_date'] = set_incident_date |
There was a problem hiding this comment.
Can we keep two parameters on top of having two flags? I don't really see any reason in favor of merging them, it may be confusing when you show a job, and it will certainly raises questions on the UI side as to why a parameter disappeared after the creation.
There was a problem hiding this comment.
Indeed, it will be clearer for the user.
$ openio-admin xcute rawx rebuild -c config.params.set_incident_date -c config.params.set_specific_incident_date 127.0.0.1:6010
+------------------------------------------+----------------------------------+
| Field | Value |
+------------------------------------------+----------------------------------+
| config.params.set_incident_date | False |
| config.params.set_specific_incident_date | None |
+------------------------------------------+----------------------------------+
$ openio-admin xcute rawx rebuild -c config.params.set_incident_date -c config.params.set_specific_incident_date 127.0.0.1:6010 --set-incident-date
+------------------------------------------+----------------------------------+
| Field | Value |
+------------------------------------------+----------------------------------+
| config.params.set_incident_date | True |
| config.params.set_specific_incident_date | 1585815292 |
+------------------------------------------+----------------------------------+
$ openio-admin xcute rawx rebuild -c config.params.set_incident_date -c config.params.set_specific_incident_date 127.0.0.1:6010 --set-specific-incident-date 1685815292
+------------------------------------------+----------------------------------+
| Field | Value |
+------------------------------------------+----------------------------------+
| config.params.set_incident_date | True |
| config.params.set_specific_incident_date | 1685815292 |
+------------------------------------------+----------------------------------+
$ openio-admin xcute rawx rebuild -c config.params.set_incident_date -c config.params.set_specific_incident_date 127.0.0.1:6010 --set-incident-date --set-specific-incident-date 1785815292
+------------------------------------------+----------------------------------+
| Field | Value |
+------------------------------------------+----------------------------------+
| config.params.set_incident_date | True |
| config.params.set_specific_incident_date | 1785815292 |
+------------------------------------------+----------------------------------+
AymericDu
force-pushed
the
xcute-allow-to-set-incident-date-when-rebuilding
branch
from
6f8690a to
61bbcaf
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Allow to set incident date when rebuilding
ISSUE TYPE
COMPONENT NAME
xcuteSDS VERSION