Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Python API: Allow to cache container metadata #2013

Merged

Conversation

AymericDu
Copy link
Member

SUMMARY

Allow to cache container metadata

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • Python API
SDS VERSION
openio 4.9.1.dev1

@AymericDu AymericDu requested review from murlock and fvennetier April 3, 2020 15:49
CMakeLists.txt Outdated
@@ -22,7 +22,7 @@ if (NOT DEFINED OIOSDS_RELEASE)
set(OIOSDS_RELEASE master)
endif ()
if (NOT DEFINED OIOSDS_PROJECT_VERSION_SHORT)
set(OIOSDS_PROJECT_VERSION_SHORT "4.8")
set(OIOSDS_PROJECT_VERSION_SHORT "4.9")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.10

@@ -41,7 +41,7 @@
from oio.common.storage_functions import _sort_chunks, fetch_stream, \
fetch_stream_ec
from oio.common.fullpath import encode_fullpath
from oio.common.cache import del_cached_metadata
from oio.common.cache import del_cached_object_metadata
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is supposed to be an internal API, and it has not been largely diffused yet, but please don't take the habit to rename exposed methods.

@fvennetier fvennetier force-pushed the python-api-allow-to-cache-container-metadata branch from aa11f36 to a45a82d Compare April 6, 2020 10:09
@codecov-io
Copy link

codecov-io commented Apr 6, 2020

Codecov Report

Merging #2013 into 4.x will increase coverage by 0.03%.
The diff coverage is 98.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##              4.x    #2013      +/-   ##
==========================================
+ Coverage   80.66%   80.68%   +0.03%     
==========================================
  Files         375      375              
  Lines       70801    70887      +86     
==========================================
+ Hits        57104    57190      +86     
  Misses      13575    13575              
  Partials      122      122              
Impacted Files Coverage Δ
oio/container/client.py 84.83% <95.84%> (+0.11%) ⬆️
oio/common/cache.py 94.45% <96.78%> (+0.70%) ⬆️
oio/api/object_storage.py 79.70% <100.00%> (-1.12%) ⬇️
tests/functional/api/test_objectstorage.py 97.56% <100.00%> (+0.11%) ⬆️
meta0v2/meta0_remote.c 74.29% <0.00%> (-8.57%) ⬇️
tests/functional/audit/test_audit_storage.py 83.74% <0.00%> (-7.31%) ⬇️
tests/unit/api/test_container_client.py 92.86% <0.00%> (-7.14%) ⬇️
tests/functional/directory/test_admin.py 93.62% <0.00%> (-6.38%) ⬇️
metautils/lib/volume_lock.c 70.00% <0.00%> (-5.00%) ⬇️
meta1v2/meta1_prefixes.c 75.78% <0.00%> (-3.09%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee11ba...a45a82d. Read the comment docs.

@fvennetier fvennetier mentioned this pull request Apr 6, 2020
@murlock murlock force-pushed the python-api-allow-to-cache-container-metadata branch from b6e7420 to bcf08d3 Compare April 7, 2020 08:02
@murlock murlock force-pushed the python-api-allow-to-cache-container-metadata branch from bcf08d3 to 4f3ec79 Compare April 7, 2020 08:04
@murlock murlock merged commit 42f99f9 into open-io:4.x Apr 7, 2020
@AymericDu AymericDu deleted the python-api-allow-to-cache-container-metadata branch April 14, 2020 08:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants