proxy: map more low-level errors to Service Unavailable (503) #2098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some low-level errors like CODE_AVOIDED (8) did not have a particular mapping to high-level errors, and thus triggered the ambiguous Internal Server Error (500) error. We choose to map these error to the Service Unavailable (503) which is better managed by calling application (they usually retry the request after a delay).
AymericDu
approved these changes
Nov 30, 2020
fvennetier
deleted the
better-management-of-errors-due-to-down-services
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Some low-level errors like CODE_AVOIDED (8) did not have a particular mapping to high-level errors, and thus triggered the ambiguous Internal Server Error (500) error. We choose to map these error to the Service Unavailable (503) which is better managed by calling applications (they usually retry the request after a delay).
ISSUE TYPE
COMPONENT NAME
SDS VERSION