xcute: Save sent tasks before they are processed #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fvennetier
approved these changes
Dec 14, 2020
oio/xcute/orchestrator.py
Outdated
| if exc is not None: | ||
| self.logger.warn( | ||
| '[job_id=%s] Job has not been updated ' | ||
| 'with the sent tasks: %s', job_id, exc) | ||
| '[job_id=%s] Job could not updated ' |
There was a problem hiding this comment.
Could not update (without the 'd').
oio/xcute/orchestrator.py
Outdated
| old_last_sent) | ||
| if exc is not None: | ||
| self.logger.warn( | ||
| '[job_id=%s] Job could not aborted ' |
oio/xcute/orchestrator.py
Outdated
|
|
||
| _, exc = self.handle_backend_errors(self.backend.free, job_id) | ||
| if exc is not None: | ||
| self.logger.warn( | ||
| '[job_id=%s] Job has not been freed: %s', job_id, exc) | ||
| '[job_id=%s] Job could not freed: %s', job_id, exc) |
AymericDu
force-pushed
the
xcute-save-sent-tasks-before-they-are-processed
branch
from
2198629 to
e0ceebb
Compare
fvennetier
reviewed
Dec 14, 2020
oio/xcute/orchestrator.py
Outdated
|
|
||
| _, exc = self.handle_backend_errors(self.backend.free, job_id) | ||
| if exc is not None: | ||
| self.logger.warn( | ||
| '[job_id=%s] Job has not been freed: %s', job_id, exc) | ||
| '[job_id=%s] Job not be freed: %s', job_id, exc) |
There was a problem hiding this comment.
"Job has not been freed" was correct. "Job not freed" would be correct. "Job not be freed" sounds funny.
In some cases, the task was processed before updating the list of sent tasks
AymericDu
force-pushed
the
xcute-save-sent-tasks-before-they-are-processed
branch
from
e0ceebb to
cb207f9
Compare
Codecov Report
@@ Coverage Diff @@
## 5.x #2101 +/- ##
==========================================
+ Coverage 78.67% 79.47% +0.80%
==========================================
Files 379 394 +15
Lines 73787 75442 +1655
Branches 6995 6994 -1
==========================================
+ Hits 58045 59950 +1905
+ Misses 15641 15247 -394
- Partials 101 245 +144
Continue to review full report at Codecov.
|
murlock
approved these changes
Dec 18, 2020
AymericDu
deleted the
xcute-save-sent-tasks-before-they-are-processed
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Save sent tasks before they are processed.
In some cases, the task was processed before updating the list of sent tasks.
ISSUE TYPE
COMPONENT NAME
xcuteSDS VERSION