-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
xcute: Improve job's listing #2104
Conversation
bc36fe9
to
9c00adc
Compare
oio/cli/admin/xcute/job.py
Outdated
parser.add_argument( | ||
'--type', | ||
help='Filter jobs with the specified job type (%s)' | ||
% ', '.join(JOB_TYPES.keys())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you should use choices
instead
continue | ||
if job_type and job_info['job.type'] != job_type: | ||
continue | ||
if job_lock and not fnmatchcase( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it really necessary to use fnmatchcase
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With fnmatchcase
, we allow listing a single service type (rawx/*
), a single server (*/127.0.0.1
), or even a single site.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
9c00adc
to
49463d7
Compare
49463d7
to
b14730d
Compare
SUMMARY
Improve job's listing
ISSUE TYPE
COMPONENT NAME
SDS VERSION
ADDITIONAL INFORMATION