Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Python API: Return actual rebuilt size when rebuilding chunks #2114

Conversation

AymericDu
Copy link
Member

SUMMARY

Return actual rebuilt size when rebuilding chunk

The rebuilt size was good for the duplicated chunk.
But the rebuilt size was wrong for chunk in EC.
The rebuilt size was the metachunk size, but it must be the chunk size.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • Python API
  • Admin CLI
  • oio-blob-rebuilder
SDS VERSION
openio 5.8.1.dev1

The rebuilt size was good for the duplicated chunk.
But the rebuilt size was wrong for chunk in EC.
The rebuilt size was the metachunk size, but it must be the chunk size.
@fvennetier fvennetier changed the title Python API: Return actual rebuilt size when rebuilding chunk Python API: Return actual rebuilt size when rebuilding chunks Jan 19, 2021
@codecov-io
Copy link

codecov-io commented Jan 19, 2021

Codecov Report

Merging #2114 (3e30798) into 5.x (23625df) will increase coverage by 0.03%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              5.x    #2114      +/-   ##
==========================================
+ Coverage   79.31%   79.33%   +0.03%     
==========================================
  Files         394      394              
  Lines       75524    75522       -2     
  Branches     7013     7012       -1     
==========================================
+ Hits        59894    59909      +15     
+ Misses      15385    15368      -17     
  Partials      245      245              
Impacted Files Coverage Δ
oio/content/ec.py 56.46% <50.00%> (-0.92%) ⬇️
oio/blob/operator.py 65.00% <100.00%> (+1.37%) ⬆️
oio/content/plain.py 73.69% <100.00%> (+0.47%) ⬆️
meta0v2/meta0_remote.c 78.05% <0.00%> (-7.31%) ⬇️
tests/unit/api/test_container_client.py 92.86% <0.00%> (-7.14%) ⬇️
oio/common/storage_functions.py 85.63% <0.00%> (-4.57%) ⬇️
meta1v2/meta1_prefixes.c 76.81% <0.00%> (-3.09%) ⬇️
meta2v2/meta2_filters_action_container.c 60.28% <0.00%> (-2.05%) ⬇️
...sts/functional/content/test_content_perfectible.py 82.36% <0.00%> (-1.96%) ⬇️
oio/account/client.py 81.49% <0.00%> (-1.85%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23625df...3e30798. Read the comment docs.

@AymericDu AymericDu merged commit 54b1065 into open-io:5.x Jan 19, 2021
@AymericDu AymericDu deleted the python-api-return-actual-rebuilt-size-when-rebuilding-chunk branch January 19, 2021 15:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants