Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Day 1 - Better Defaults: Filter default metadata #19762

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Day 1 - Better Defaults: Filter default metadata #19762

wants to merge 32 commits into from
+11,224 −4,878

Conversation

harshsoni2024
Copy link
Contributor

@harshsoni2024 harshsoni2024 commented Feb 12, 2025 •
edited
Loading

Describe your changes:

Default filter pattern for database service entities(database, service, schema) applied on ingestion. Currently applied for below connectors only.

  • mysql
  • mssql
  • postgres
  • databricks
  • unity catalog
  • oracle
  • redshift
  • snowflake

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Feb 12, 2025
@harshsoni2024 harshsoni2024 removed Ingestion safe to test Add this label to run secure Github workflows on PRs labels Feb 12, 2025
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Feb 14, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 14, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.52% (42452/66831) 38.26% (16592/43372) 42.94% (5069/11805)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@pmbrull pmbrull pmbrull left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harshsoni2024 @pmbrull @IceS2 @aniketkatkar97