Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(ui): Persona comments and sonar issues #20011

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

fix(ui): Persona comments and sonar issues #20011

wants to merge 32 commits into from

Conversation

chirag-madlani
Copy link
Collaborator

@chirag-madlani chirag-madlani commented Feb 27, 2025 •
edited
Loading

Describe your changes:

Fixes: Sonar comments from Persona changes
Fix for persona breaking without refresh
Fix undefined tab case
added Unit test as well as playwright tests

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Feb 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
 63.56% (42444/66780) 38.31% (16496/43055) 42.9% (5068/11813)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
17.2% Duplication on New Code

See analysis details on SonarQube Cloud

@chirag-madlani chirag-madlani marked this pull request as draft March 13, 2025 09:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chirag-madlani @ShaileshParmar11