Redesign : Worked on Redesign of header component #20098
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
| }: { | ||
| label: string; | ||
| value: string | number; | ||
| dataTestId?: string; | ||
| isNewDesign?: boolean; |
There was a problem hiding this comment.
We don't need this.
This is used at one place only and we want to redesign, so remove this param
| @@ -116,19 +124,27 @@ export const ExtraInfoLink = ({ | |||
| href, | |||
| newTab = false, | |||
| ellipsis = false, | |||
| isNewDesign = false, | |||
There was a problem hiding this comment.
We don't need this.
This is used at one place only and we want to redesign, so remove this param
| )} | ||
| {!excludeEntityService && ( | ||
| <Tooltip title={t('label.open-task-plural')}> | ||
| <Button |
| .data-asset-header-metadata { | ||
| height: 102px; | ||
| border-radius: 12px; | ||
| border: 0.5px solid #d5d7da; |
There was a problem hiding this comment.
Perform this change at all places
| @@ -46,6 +47,7 @@ export const DomainLabel = ({ | |||
| textClassName, | |||
| showDomainHeading = false, | |||
| multiple = false, | |||
| isNewDesign = false, | |||
There was a problem hiding this comment.
recommend using showDomainHeading
| @@ -220,7 +220,7 @@ export const renderDomainLink = ( | |||
| textClassName | |||
| )} | |||
| data-testid="domain-link" | |||
| style={{ color: '#535862', marginBottom: '8px' }} | |||
| style={{ color: '#535862' }} | |||
| @@ -75,3 +75,22 @@ button { | |||
| color: @primary-color; | |||
| background: transparent; | |||
| } | |||
| .ant-btn-group, | |||
| .ant-btn-group-sm, | |||
| .data-asset-button-group { | |||
There was a problem hiding this comment.
move this to component level
| @@ -127,7 +129,7 @@ const EntityHeaderTitle = ({ | |||
| entity: capitalize(entityType), | |||
| })}> | |||
| <Button | |||
| className="entity-follow-button text-sm " | |||
| className="entity-follow-button d-flex gap-1 align-center justify-center p-y-xss p-x-sm w-fit-content border-none h-auto text-sm " | |||
There was a problem hiding this comment.
can we handle styling through this class only? entity-follow-button
| @@ -1223,6 +1222,7 @@ | |||
| "started": "Gestartet", | |||
| "started-following": "Hat begonnen zu folgen", | |||
| "starting-offset": "Start-Offset", | |||
| "state": "Zustand", | |||
| @@ -1223,6 +1222,7 @@ | |||
| "started": "प्रारंभ केले", | |||
| "started-following": "अनुसरण करणे प्रारंभ केले", | |||
| "starting-offset": "प्रारंभिक ऑफसेट", | |||
| "state": "राज्य", | |||
There was a problem hiding this comment.
Can we check the translation
| @@ -1223,6 +1222,7 @@ | |||
| "started": "Gestart", | |||
| "started-following": "Begonnen met volgen", | |||
| "starting-offset": "Startoffset", | |||
| "state": "Status", | |||
| @@ -1223,6 +1222,7 @@ | |||
| "started": "شروع شد", | |||
| "started-following": "شروع به دنبال کردن شد", | |||
| "starting-offset": "آفست شروع", | |||
| "state": "State", | |||
| @@ -1223,6 +1222,7 @@ | |||
| "started": "Начато", | |||
| "started-following": "Начало отслеживания", | |||
| "starting-offset": "Начальное смещение", | |||
| "state": "State", | |||
| @@ -1223,6 +1222,7 @@ | |||
| "started": "เริ่มต้นแล้ว", | |||
| "started-following": "เริ่มติดตาม", | |||
| "starting-offset": "ออฟเซ็ตเริ่มต้น", | |||
| "state": "State", | |||
| @@ -1223,6 +1222,7 @@ | |||
| "started": "已开始", | |||
| "started-following": "开始关注", | |||
| "starting-offset": "起始偏移量", | |||
| "state": "State", | |||
|
Describe your changes:
I worked on redesigning the Header component as per the new UI specifications. The updated design aligns with the latest UI/UX guidelines, improving visual consistency and user experience.
I have updated usage summery and source URL to pipeline details page. I have also updated payload adding an extra filed
usageSummeryType of change:
Before
After
Screen.Recording.2025-03-13.at.3.38.35.PM.mp4
Checklist:
Fixes <issue-number>: <short explanation>