Activity Feed Tab Revamp #20167
Activity Feed Tab Revamp #20167
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
shrushti2000
added
the
safe to test
Jest test CoverageUI tests summary
|
| @@ -136,6 +136,7 @@ | |||
| code { | |||
| white-space: break-spaces; | |||
| color: @text-color; | |||
| font-family: Inter, sans-serif; | |||
There was a problem hiding this comment.
@shrushti2000 why we are doing this?
| const clone = contentRef.current.cloneNode(true) as HTMLElement; | ||
| clone.style.maxHeight = 'none'; | ||
| clone.style.position = 'absolute'; | ||
| clone.style.visibility = 'hidden'; | ||
| document.body.appendChild(clone); | ||
| const fullHeight = clone.scrollHeight; | ||
| document.body.removeChild(clone); | ||
|
|
||
| // Compare the full height with two lines height | ||
| setShouldShowViewMore(fullHeight > twoLinesHeight); |
There was a problem hiding this comment.
Not sure why we want this logic
|
This PR introduces Activity Feed Revamp design changes across all the pages
and Playwright fixes for ActivityFeed.spec
Database Scehama Page
PipelineDetails Page
Topic Page
ML Models
Containers
SearchIndex
Glossaries
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>