Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support Json annotations #119

Merged
merged 11 commits into from
Aug 27, 2020
Merged

Conversation

kennymckormick
Copy link
Member

@kennymckormick kennymckormick commented Aug 14, 2020

Support the new json annotation format, which is more scalable than txt files:

  1. You can use the command python tools/data/anno_txt2json.py annotation.txt to convert it from txt to json.
  2. The dataset can automatically detect json annotation list and load it.
  3. When the repo decides to switch from txt to json, just change the default option of output_format in build_file_list.py to 'json'

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #119 into master will decrease coverage by 0.37%.
The diff coverage is 13.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   85.53%   85.15%   -0.38%     
==========================================
  Files          76       76              
  Lines        4155     4177      +22     
  Branches      662      667       +5     
==========================================
+ Hits         3554     3557       +3     
- Misses        494      512      +18     
- Partials      107      108       +1     
Flag Coverage Δ
#unittests 85.15% <13.04%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/datasets/rawframe_dataset.py 85.85% <0.00%> (-1.78%) ⬇️
mmaction/datasets/video_dataset.py 82.53% <0.00%> (-2.71%) ⬇️
mmaction/models/backbones/resnet_tsm.py 95.08% <ø> (ø)
mmaction/datasets/base.py 67.24% <11.11%> (-25.26%) ⬇️
mmaction/models/backbones/resnet3d_csn.py 100.00% <100.00%> (+2.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 995c039...9728735. Read the comment docs.

@kennymckormick kennymckormick changed the title output json_list WIP: support json data list Aug 14, 2020
@dreamerlin dreamerlin added the WIP work in progress label Aug 14, 2020
@kennymckormick kennymckormick changed the title WIP: support json data list Support Json annotations Aug 19, 2020
@dreamerlin dreamerlin removed the WIP work in progress label Aug 25, 2020
@dreamerlin
Copy link
Collaborator

You can remove the "WIP" label when the PR is ready

@innerlee innerlee merged commit cdcc5b4 into open-mmlab:master Aug 27, 2020
@kennymckormick kennymckormick deleted the json_list branch September 7, 2020 09:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants