-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Support Json annotations #119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
- Coverage 85.53% 85.15% -0.38%
==========================================
Files 76 76
Lines 4155 4177 +22
Branches 662 667 +5
==========================================
+ Hits 3554 3557 +3
- Misses 494 512 +18
- Partials 107 108 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dreamerlin
reviewed
Aug 14, 2020
dreamerlin
reviewed
Aug 15, 2020
dreamerlin
reviewed
Aug 15, 2020
dreamerlin
reviewed
Aug 19, 2020
dreamerlin
reviewed
Aug 19, 2020
dreamerlin
reviewed
Aug 19, 2020
dreamerlin
reviewed
Aug 19, 2020
dreamerlin
reviewed
Aug 19, 2020
dreamerlin
reviewed
Aug 19, 2020
dreamerlin
reviewed
Aug 19, 2020
dreamerlin
approved these changes
Aug 25, 2020
You can remove the "WIP" label when the PR is ready |
innerlee
approved these changes
Aug 27, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the new json annotation format, which is more scalable than txt files:
python tools/data/anno_txt2json.py annotation.txt
to convert it from txt to json.build_file_list.py
to 'json'