[Enhance] Add cfg-options in argument
#212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamerlin
changed the title
cfg-optionscfg-options
Codecov Report
@@ Coverage Diff @@
## master #212 +/- ##
==========================================
- Coverage 85.08% 85.03% -0.06%
==========================================
Files 81 81
Lines 5276 5258 -18
Branches 849 849
==========================================
- Hits 4489 4471 -18
Misses 648 648
Partials 139 139
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
innerlee
reviewed
Sep 28, 2020
dreamerlin
force-pushed
the
customized
branch
2 times, most recently
from
31abcd7 to
f3cf089
Compare
innerlee
reviewed
Oct 15, 2020
tools/test.py
Outdated
| nargs='+', | ||
| action=DictAction, | ||
| help='override some settings in the used config, the key-value pair ' | ||
| 'in xxx=yyy format will be merged into config file.') |
There was a problem hiding this comment.
use an example of overwriting two options would be great
There was a problem hiding this comment.
Example is added
innerlee
reviewed
Oct 15, 2020
tools/test.py
Outdated
| cfg = Config.fromfile(args.config) | ||
|
|
||
| if args.cfg_options is not None: | ||
| cfg.merge_from_dict(args.cfg_options) |
There was a problem hiding this comment.
if --cfg-options defaults to an empty dict, can the above two lines be reduced into one line?
There was a problem hiding this comment.
set default={} now
dreamerlin
force-pushed
the
customized
branch
from
d2ad88f to
4c2dbe2
Compare
dreamerlin
changed the title
cfg-optionscfg-options in argument
innerlee
approved these changes
Oct 16, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.