Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] Fix BC-breaking of timm for TSN #2497

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

cir7
Copy link
Collaborator

@cir7 cir7 commented May 25, 2023

Motivation

[Fix] Fix BC-breaking of timm for TSN

@cir7 cir7 closed this May 25, 2023
@cir7 cir7 reopened this May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 28.00% and project coverage change: +0.02 🎉

Comparison is base (b94df49) 76.96% compared to head (974cd7c) 76.99%.

❗ Current head 974cd7c differs from pull request most recent head 8bae4cd. Consider uploading reports for the commit 8bae4cd to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #2497      +/-   ##
===========================================
+ Coverage    76.96%   76.99%   +0.02%     
===========================================
  Files          159      159              
  Lines        12598    12617      +19     
  Branches      2116     2121       +5     
===========================================
+ Hits          9696     9714      +18     
- Misses        2393     2398       +5     
+ Partials       509      505       -4     
Flag Coverage Δ
unittests 76.99% <28.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/testing/__init__.py 100.00% <ø> (ø)
mmaction/models/recognizers/base.py 70.32% <14.28%> (+1.97%) ⬆️
mmaction/models/recognizers/recognizer2d.py 74.57% <45.45%> (+14.96%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cir7 cir7 force-pushed the lilin/fix_tsn_custom_backbones branch from 394cb73 to d4ea9c7 Compare May 26, 2023 02:52
@cir7 cir7 force-pushed the lilin/fix_tsn_custom_backbones branch from d4ea9c7 to cd0135d Compare May 26, 2023 02:56
@cir7 cir7 closed this Jun 9, 2023
@cir7 cir7 reopened this Jun 9, 2023
@cir7 cir7 closed this Jun 9, 2023
@cir7 cir7 reopened this Jun 9, 2023
@cir7 cir7 merged commit 7be50ff into open-mmlab:dev-1.x Jun 12, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants