Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Support LFB #553

Merged
merged 16 commits into from
Mar 3, 2021
Merged

[Feature] Support LFB #553

merged 16 commits into from
Mar 3, 2021

Conversation

congee524
Copy link
Contributor

@congee524 congee524 commented Jan 20, 2021

Support Long-Term Feature Bank.

@congee524 congee524 added the WIP work in progress label Jan 20, 2021
@congee524 congee524 requested a review from dreamerlin January 20, 2021 13:54
@codecov
Copy link

codecov bot commented Jan 20, 2021

Codecov Report

Merging #553 (e611ec3) into master (ecf0208) will decrease coverage by 0.45%.
The diff coverage is 73.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #553      +/-   ##
==========================================
- Coverage   84.75%   84.30%   -0.46%     
==========================================
  Files         127      130       +3     
  Lines        8972     9338     +366     
  Branches     1511     1572      +61     
==========================================
+ Hits         7604     7872     +268     
- Misses       1007     1071      +64     
- Partials      361      395      +34     
Flag Coverage Δ
unittests 84.29% <73.19%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/models/heads/roi_head.py 26.41% <20.00%> (-1.85%) ⬇️
mmaction/models/heads/lfb_infer_head.py 47.50% <47.50%> (ø)
mmaction/models/heads/fbo_head.py 78.49% <78.49%> (ø)
mmaction/models/common/lfb.py 88.63% <88.63%> (ø)
mmaction/datasets/ava_dataset.py 90.60% <100.00%> (ø)
mmaction/models/__init__.py 100.00% <100.00%> (ø)
mmaction/models/backbones/resnet3d.py 90.66% <100.00%> (+0.05%) ⬆️
mmaction/models/common/__init__.py 100.00% <100.00%> (ø)
mmaction/models/heads/__init__.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecf0208...c75de61. Read the comment docs.

@congee524 congee524 marked this pull request as ready for review February 18, 2021 12:41
@congee524 congee524 changed the title Support lfb [Feature] Support LFB Feb 19, 2021
@congee524 congee524 force-pushed the support_lfb branch 4 times, most recently from 9b5ee1c to b71c82d Compare February 23, 2021 03:36
@congee524 congee524 added need test waiting for ckpts and removed WIP work in progress labels Feb 23, 2021
@congee524 congee524 force-pushed the support_lfb branch 3 times, most recently from 7a87f46 to 471ee91 Compare February 26, 2021 10:19
@congee524
Copy link
Contributor Author

congee524 commented Feb 26, 2021

This PR and the ckpt have been almost ready. I will add unit tests next week. Maybe you could review it when you are free. :p

@innerlee
Copy link
Contributor

innerlee commented Mar 1, 2021

The code looks good

@congee524
Copy link
Contributor Author

We don't have a unit test for detectors like test_recognizers and test_localizers right now, so maybe we need a PR to fix it.

@congee524
Copy link
Contributor Author

This PR is ready.

@innerlee innerlee merged commit 59ae4ea into open-mmlab:master Mar 3, 2021
@dreamerlin dreamerlin mentioned this pull request Mar 3, 2021
10 tasks
@congee524 congee524 deleted the support_lfb branch March 16, 2021 04:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants