Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Support GPU Normalize #586

Merged
merged 14 commits into from
Feb 19, 2021

Conversation

congee524
Copy link
Contributor

@congee524 congee524 commented Feb 2, 2021

fix #470

@codecov
Copy link

codecov bot commented Feb 2, 2021

Codecov Report

Merging #586 (d69cbf9) into master (d8f6f34) will increase coverage by 0.02%.
The diff coverage is 92.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #586      +/-   ##
==========================================
+ Coverage   84.31%   84.33%   +0.02%     
==========================================
  Files         124      125       +1     
  Lines        8774     8824      +50     
  Branches     1468     1479      +11     
==========================================
+ Hits         7398     7442      +44     
- Misses       1019     1022       +3     
- Partials      357      360       +3     
Flag Coverage Δ
unittests 84.32% <92.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/core/evaluation/eval_hooks.py 86.09% <ø> (ø)
mmaction/datasets/pipelines/formating.py 88.60% <0.00%> (-1.14%) ⬇️
mmaction/utils/module_hooks.py 95.74% <95.74%> (ø)
mmaction/utils/__init__.py 100.00% <100.00%> (ø)
mmaction/core/evaluation/accuracy.py 92.27% <0.00%> (-0.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f6f34...a9a13f1. Read the comment docs.

mmaction/datasets/pipelines/formating.py Outdated Show resolved Hide resolved
mmaction/utils/module_hooks.py Outdated Show resolved Hide resolved
@congee524 congee524 changed the title gpu normalize draft support gpu normalize Feb 3, 2021
@congee524 congee524 force-pushed the support_gpu_normalize branch from a5755d1 to 68f81b7 Compare February 5, 2021 07:31
@congee524
Copy link
Contributor Author

@innerlee kindly ping :p

@innerlee
Copy link
Contributor

innerlee commented Feb 5, 2021

I suppose there should be more reviewers? cc. @hellock

@congee524
Copy link
Contributor Author

Test GPU Normalize on 1080TI, TITAN XP, and Tesla V100.
Only on V100, GPU Normalize can significantly increase the training speed and shorten the training time by nearly half.

@innerlee
Copy link
Contributor

Okay, you can train a full model in V100, and upload the ckpt to modelzoo for future reference.

@congee524 congee524 changed the title support gpu normalize [Feature] support gpu normalize Feb 18, 2021
@innerlee innerlee merged commit 503a37c into open-mmlab:master Feb 19, 2021
@congee524 congee524 deleted the support_gpu_normalize branch February 20, 2021 01:52
@dreamerlin dreamerlin mentioned this pull request Feb 25, 2021
9 tasks
@congee524 congee524 changed the title [Feature] support gpu normalize [Feature] Support GPU Normalize Feb 26, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPU normalize
3 participants