Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] Fix 806 #878

Merged
merged 2 commits into from
May 21, 2021
Merged

Conversation

irvingzhang0512
Copy link
Contributor

@irvingzhang0512 irvingzhang0512 commented May 20, 2021

Motivation

Fix #806

related comment

For ava, each video must have a fixed number(27030) of frames.
It seems OpenCV cannot do that opencv/opencv#9053 (comment)

It seems to me that the problem is that VideoCapture ignores all duplicate frames, while FFmpeg will return duplicates without issues

I would recommend that AVA dataset should not extract frames by OpenCV and we should remove related docs in tutorials.

For other dataset, there is no requirement on the number of frames for each video, so extracting frames by OpenCV is ok.

Modification

Remove docs and script that extracting ava rgb frames by OpenCV

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #878 (0744127) into master (1056d29) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 0744127 differs from pull request most recent head 49b08d3. Consider uploading reports for the commit 49b08d3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #878      +/-   ##
==========================================
+ Coverage   83.26%   83.29%   +0.03%     
==========================================
  Files         129      129              
  Lines        9421     9421              
  Branches     1612     1612              
==========================================
+ Hits         7844     7847       +3     
+ Misses       1185     1184       -1     
+ Partials      392      390       -2     
Flag Coverage Δ
unittests 83.29% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/datasets/pipelines/augmentations.py 93.24% <0.00%> (+0.13%) ⬆️
mmaction/core/evaluation/accuracy.py 93.18% <0.00%> (+0.90%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1056d29...49b08d3. Read the comment docs.

@dreamerlin dreamerlin merged commit 14955d3 into open-mmlab:master May 21, 2021
@irvingzhang0512 irvingzhang0512 deleted the fix-ava-preparation branch June 11, 2021 17:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileNotFoundError for AVA dataset
2 participants