Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Improvement] Rename lr modules to scheduler #916

Merged
merged 3 commits into from
Jun 10, 2021

Conversation

dreamerlin
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #916 (3f5af8e) into master (f8b595a) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
- Coverage   83.57%   83.54%   -0.04%     
==========================================
  Files         132      132              
  Lines        9966     9966              
  Branches     1718     1718              
==========================================
- Hits         8329     8326       -3     
- Misses       1218     1222       +4     
+ Partials      419      418       -1     
Flag Coverage Δ
unittests 83.54% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/core/__init__.py 100.00% <100.00%> (ø)
mmaction/core/scheduler/__init__.py 100.00% <100.00%> (ø)
mmaction/core/scheduler/lr_updater.py 96.55% <100.00%> (ø)
mmaction/datasets/pipelines/augmentations.py 92.29% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8b595a...3f5af8e. Read the comment docs.

Copy link
Member

@kennymckormick kennymckormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also replace the '.lr' to '.scheduler' in api.rst

@kennymckormick kennymckormick merged commit f007661 into open-mmlab:master Jun 10, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants