Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support number counting for flow-wise filename template #922

Merged
merged 1 commit into from
Jun 12, 2021

Conversation

irvingzhang0512
Copy link
Contributor

@irvingzhang0512 irvingzhang0512 commented Jun 11, 2021

Motivation

  1. As inference_recognizer on optical flow model is throwing "FileNotFoundError, No such file or directory" accessing non existent frame on rawframe video #904 and the following comment shows, for now, in inference_recognizer we assumes files in video_path are all named with filename_tmpl. This pr removes the above restriction.

# assuming files in ``video_path`` are all named with ``filename_tmpl`` # noqa: E501

  1. We have already provided a way to fix bug in TSN temporal stream #565. However, we haven't modified related configs. So if we train flow models with default config, this shape mismatch bug still occurs.

Modification

  1. For inference_recognizer, this pr count the file that filename format matches filename_impl, add some unittests.
  2. For TSN Flow configs, this pr modifies in_channels of backbone

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #922 (e60e6ab) into master (f007661) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #922      +/-   ##
==========================================
+ Coverage   83.58%   83.63%   +0.04%     
==========================================
  Files         132      132              
  Lines        9977     9983       +6     
  Branches     1720     1722       +2     
==========================================
+ Hits         8339     8349      +10     
+ Misses       1219     1218       -1     
+ Partials      419      416       -3     
Flag Coverage Δ
unittests 83.63% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/apis/inference.py 89.85% <100.00%> (+8.90%) ⬆️
mmaction/datasets/pipelines/augmentations.py 91.95% <0.00%> (-0.81%) ⬇️
mmaction/datasets/pipelines/formating.py 92.00% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f007661...e60e6ab. Read the comment docs.

@dreamerlin dreamerlin changed the title Fix 904 Support number counting for flow-wise filename template Jun 11, 2021
@dreamerlin
Copy link
Collaborator

Thanks for your contribution for MMAction2!

@dreamerlin dreamerlin merged commit 3488f90 into open-mmlab:master Jun 12, 2021
@irvingzhang0512 irvingzhang0512 deleted the fix904 branch June 14, 2021 16:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants