Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Improvement] Remove Flips #996

Merged
merged 3 commits into from
Jul 6, 2021

Conversation

kennymckormick
Copy link
Member

No description provided.

@kennymckormick kennymckormick requested a review from dreamerlin July 6, 2021 04:21
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #996 (e7e3040) into master (b38e9ad) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #996      +/-   ##
==========================================
+ Coverage   83.36%   83.41%   +0.04%     
==========================================
  Files         135      135              
  Lines       10311    10311              
  Branches     1764     1764              
==========================================
+ Hits         8596     8601       +5     
+ Misses       1284     1280       -4     
+ Partials      431      430       -1     
Flag Coverage Δ
unittests 83.41% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/core/evaluation/accuracy.py 92.27% <0.00%> (-0.91%) ⬇️
mmaction/datasets/pipelines/augmentations.py 91.19% <0.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b38e9ad...e7e3040. Read the comment docs.

@kennymckormick kennymckormick linked an issue Jul 6, 2021 that may be closed by this pull request
@kennymckormick
Copy link
Member Author

@dreamerlin Plz take a look.

@innerlee
Copy link
Contributor

innerlee commented Jul 6, 2021

flop flip

@kennymckormick kennymckormick changed the title [Improvement] Remove Flops [Improvement] Remove Flips Jul 6, 2021
@kennymckormick kennymckormick requested a review from innerlee July 6, 2021 05:47
@innerlee
Copy link
Contributor

innerlee commented Jul 6, 2021

One thing to check is that the modified configs could run successfully, especially for those detection related.
The format bundle in mmdet requires keys like flip directions, so det will raise an error if such keys do not exist.

@kennymckormick
Copy link
Member Author

One thing to check is that the modified configs could run successfully, especially for those detection related.
The format bundle in mmdet requires keys like flip directions, so det will raise an error if such keys do not exist.

Keys added by Flip ('flip', 'flip_direction') is not further used, besides, we haven't changed the detection config files.

@kennymckormick kennymckormick merged commit c6b75d0 into open-mmlab:master Jul 6, 2021
@kennymckormick kennymckormick deleted the remove_flips branch July 7, 2021 05:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant items in val/test pipeline among config files
3 participants