-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[Fix] Read in rb mode then decode #983
Conversation
Codecov Report
@@ Coverage Diff @@
## master #983 +/- ##
==========================================
- Coverage 65.27% 65.19% -0.09%
==========================================
Files 151 154 +3
Lines 9619 9911 +292
Branches 1741 1807 +66
==========================================
+ Hits 6279 6461 +182
- Misses 3017 3116 +99
- Partials 323 334 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Kindly ping @wangruohui |
@wangruohui ,lint failed. The comments are too long and need to be separated in two lines. |
On Windows :
will decode the content of the file based on windows's system language setting.
Using
rb
mode then decode within python will force using utf-8.note: the ruby precommit hook does not work on windows and I will recover it when everything other is good before actual merge.