Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Feature] Support auto import modules from registry. #9143

Merged
merged 14 commits into from
Feb 7, 2023
Merged

[Feature] Support auto import modules from registry. #9143

merged 14 commits into from
Feb 7, 2023

Conversation

RangiLyu
Copy link
Member

@RangiLyu RangiLyu commented Oct 26, 2022 •
edited
Loading

Motivation

The registry now supports auto-import modules from the given location.

register_all_modules before running is no longer needed. The modules will be lazy-imported during building.

resolve open-mmlab/mmyolo#312

@ZwwWayne ZwwWayne assigned RangiLyu and unassigned wanghonglie Nov 8, 2022
@ZwwWayne ZwwWayne added this to the 3.0.0rc5 milestone Nov 21, 2022
@RangiLyu RangiLyu marked this pull request as ready for review November 28, 2022 03:44
@RangiLyu RangiLyu changed the title [Draft][Feature] Support auto import modules from registry. [Feature] Support auto import modules from registry. Nov 28, 2022
@RangiLyu RangiLyu added pending enhancement New feature or request v-3.x labels Nov 28, 2022
@zhouzaida zhouzaida mentioned this pull request Dec 4, 2022
Merged
@RangiLyu RangiLyu removed the pending label Jan 9, 2023
@RangiLyu RangiLyu requested review from hhaAndroid and ZwwWayne and removed request for hhaAndroid and HAOCHENYE January 9, 2023 05:31
@fangyixiao18 fangyixiao18 mentioned this pull request Jan 9, 2023
Merged
6 tasks
@xiexinch xiexinch mentioned this pull request Jan 12, 2023
Merged
1 task
hhaAndroid
hhaAndroid reviewed Feb 3, 2023
View reviewed changes
tools/deployment/test_torchserver.py Outdated Show resolved Hide resolved
tools/deployment/mmdet_handler.py Outdated Show resolved Hide resolved
mmdet/registry.py Show resolved Hide resolved
BIGWangYuDong
BIGWangYuDong approved these changes Feb 6, 2023
View reviewed changes
Copy link
Collaborator

@BIGWangYuDong BIGWangYuDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit 2fe0ec4 into open-mmlab:dev-3.x Feb 7, 2023
@Ben-Louis Ben-Louis mentioned this pull request Feb 7, 2023
Merged
6 tasks
@RangiLyu RangiLyu mentioned this pull request Feb 17, 2023
Open
MeowZheng pushed a commit to open-mmlab/mmsegmentation that referenced this pull request Feb 23, 2023
@xiexinch
[Feature] Support auto import modules from registry. (#2481)
039ba5d 
## Motivation

The registry now supports auto-import modules from the given location.

register_all_modules before running is no longer needed. The modules
will be lazy-imported during building.

- [x] This PR can be merged after
open-mmlab/mmengine#643. The MMEngine version
should be updated.

Ref: open-mmlab/mmdetection#9143
@sunjiahao1999 sunjiahao1999 mentioned this pull request Feb 28, 2023
Merged
yumion pushed a commit to yumion/mmdetection that referenced this pull request Jan 31, 2024
@RangiLyu @yumion
[Feature] Support auto import modules from registry. (open-mmlab#9143)
86f8d1e
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@HAOCHENYE HAOCHENYE HAOCHENYE left review comments

@BIGWangYuDong BIGWangYuDong BIGWangYuDong approved these changes

@hhaAndroid hhaAndroid hhaAndroid approved these changes

@ZwwWayne ZwwWayne Awaiting requested review from ZwwWayne

Assignees

@RangiLyu RangiLyu

Labels
enhancement New feature or request v-3.x
Projects
None yet
Milestone
3.0.0rc5
Development

Successfully merging this pull request may close these issues.
6 participants
@RangiLyu @hhaAndroid @BIGWangYuDong @HAOCHENYE @wanghonglie @ZwwWayne