Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] Fix incorrect velo indexing when formatting boxes on nuScenes #1049

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

Tai-Wang
Copy link
Member

@Tai-Wang Tai-Wang commented Nov 13, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix incorrect velocity indexing when formatting boxes on nuScenes.
Note that this fix can affect the specific evaluation result for mAVE but won't affect the final NDS because mAVE is usually larger than 1 for monocular 3D detectors (at least not affect the currently supported mono3D models).

Modification

Only fix the incorrect velocity indexing when changing nuscenes boxes to CameraInstance3DBoxes.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ZwwWayne ZwwWayne merged commit 0cd000b into open-mmlab:master Nov 13, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants