Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] Fix DynamicPillarFeaureNet incorrect index caused by modifications of PillarFeatureNet #1302

Merged
merged 2 commits into from
Mar 23, 2022

Conversation

Xiangxu-0103
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Xiangxu-0103
Copy link
Collaborator Author

Sorry for deleting the fix_dv branch in my repo by mistake and re-pull this PR.

@Tai-Wang Tai-Wang changed the title [Fix] fix DynamicPillarFeaureNet bug [Fix] Fix DynamicPillarFeaureNet incorrect index caused by modifications of PillarFeatureNet Mar 18, 2022
Copy link
Member

@Tai-Wang Tai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The performance does not change compared with that before the modifications of PillarFeatureNet while a little lower than that before coordinate system refactoring. Consider merging this PR first and then calibrating the performance by checking the dynamic voxelization.

@ZwwWayne ZwwWayne merged commit 41d77da into open-mmlab:dev Mar 23, 2022
@Xiangxu-0103 Xiangxu-0103 deleted the fix_dv branch March 30, 2022 10:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants