Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix] Bugs in nms #1479

Merged
merged 2 commits into from
May 25, 2022
Merged

[Fix] Bugs in nms #1479

merged 2 commits into from
May 25, 2022

Conversation

filaPro
Copy link
Contributor

@filaPro filaPro commented May 12, 2022

Motivation

Fix bugs introduced in #1403. This is also related to mmcv#1902.

Modification

Fix bugs, add tests from mmcv.

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #1479 (e895dd1) into dev (4422eaa) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #1479      +/-   ##
==========================================
- Coverage   50.39%   50.38%   -0.01%     
==========================================
  Files         221      221              
  Lines       18927    18928       +1     
  Branches     3118     3118              
==========================================
- Hits         9538     9537       -1     
- Misses       8811     8814       +3     
+ Partials      578      577       -1     
Flag Coverage Δ
unittests 50.38% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/core/post_processing/box3d_nms.py 27.89% <0.00%> (-0.88%) ⬇️
mmdet3d/datasets/pipelines/test_time_aug.py 51.04% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4422eaa...e895dd1. Read the comment docs.

@filaPro
Copy link
Contributor Author

filaPro commented May 12, 2022

Also put bboxes, labels and scores in the test_merge_aug_bboxes_3d to the same device. scores are updated for more determinism in case of equal values.

@ZwwWayne ZwwWayne merged commit a34e1e7 into open-mmlab:dev May 25, 2022
@filaPro filaPro deleted the fix_nms_bev branch May 25, 2022 20:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants