Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Add FCAF3D on ScanNet, S3DIS and SUN RGB-D #1547

Merged
merged 14 commits into from
Aug 1, 2022

Conversation

filaPro
Copy link
Contributor

@filaPro filaPro commented Jun 9, 2022

Motivation

Close #1219. Add FCAF3DNeckWithHead, MinkSingleStage3DDetector and RotatedIoU3DLoss. For all 3 datasets the original authors' checkpoints show exactly the same metrics. Benchmark can be added in the next PR.

Modification

Add FCAF3DHead, MinkSingleStage3DDetector and RotatedIoU3DLoss.

BC-breaking (Optional)

Fix DepthInstance3DBoxes.overlaps. BC-breaking part is merged in #1548. No.

@filaPro filaPro changed the base branch from master to dev June 9, 2022 12:47
@filaPro
Copy link
Contributor Author

filaPro commented Jun 9, 2022

The BC-breaking part of the PR is separated to #1548.

Also build problem AssertionError: MMCV==1.5.2 is used but incompatible. Please install mmcv>=1.3.8, <=1.5.0. is probably not caused by this PR.

And one more thing, the minimal version of mmcv-full should be increased to 1.5.2.

@Tai-Wang
Copy link
Member

The BC-breaking part of the PR is separated to #1548.

Also build problem AssertionError: MMCV==1.5.2 is used but incompatible. Please install mmcv>=1.3.8, <=1.5.0. is probably not caused by this PR.

And one more thing, the minimal version of mmcv-full should be increased to 1.5.2.

Hi @filaPro , thanks for your contribution! We have fixed the compatibility problem in #1537 . You can merge the latest dev and resolve conflicts to pass the CI test.

# Conflicts:
#	mmdet3d/core/bbox/structures/depth_box3d.py
#	mmdet3d/models/detectors/__init__.py
@filaPro
Copy link
Contributor Author

filaPro commented Jun 10, 2022

Will think, how to skip MinkowskiEngine in the failed test and add test for RotatedIoU3DLoss.

@filaPro filaPro changed the title [Enhance] Add FCAF3D on ScanNet, S3DIS and SUN RGB-D [Feature] Add FCAF3D on ScanNet, S3DIS and SUN RGB-D Jun 10, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #1547 (6a8054e) into dev (dea954e) will decrease coverage by 0.36%.
The diff coverage is 21.51%.

@@            Coverage Diff             @@
##              dev    #1547      +/-   ##
==========================================
- Coverage   50.16%   49.80%   -0.37%     
==========================================
  Files         223      226       +3     
  Lines       19104    19453     +349     
  Branches     3134     3174      +40     
==========================================
+ Hits         9584     9689     +105     
- Misses       8940     9177     +237     
- Partials      580      587       +7     
Flag Coverage Δ
unittests 49.80% <21.51%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/backbones/mink_resnet.py 26.31% <0.00%> (ø)
mmdet3d/models/losses/axis_aligned_iou_loss.py 91.30% <ø> (+26.08%) ⬆️
mmdet3d/models/dense_heads/fcaf3d_head.py 15.67% <15.67%> (ø)
mmdet3d/models/detectors/mink_single_stage.py 44.11% <44.11%> (ø)
mmdet3d/models/losses/rotated_iou_loss.py 45.83% <45.83%> (ø)
mmdet3d/models/dense_heads/__init__.py 100.00% <100.00%> (ø)
mmdet3d/models/detectors/__init__.py 100.00% <100.00%> (ø)
mmdet3d/models/losses/__init__.py 100.00% <100.00%> (ø)
mmdet3d/datasets/pipelines/dbsampler.py 74.07% <0.00%> (-1.73%) ⬇️
mmdet3d/models/dense_heads/centerpoint_head.py 44.05% <0.00%> (-0.69%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dea954e...6a8054e. Read the comment docs.

@filaPro
Copy link
Contributor Author

filaPro commented Jun 14, 2022

Removed DepthInstance3DBoxes.overlaps due to #1556.

@Tai-Wang
Copy link
Member

Tai-Wang commented Jul 3, 2022

Almost ready to merge. Just need to fix the minor comments.

@ZwwWayne ZwwWayne merged commit fe8f9d4 into open-mmlab:dev Aug 1, 2022
@filaPro filaPro deleted the fcaf3d branch August 4, 2022 11:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants