Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Fix]Fix pointrcnn in dev branch #1874

Merged
merged 7 commits into from
Sep 30, 2022
Merged

Conversation

VVsssssk
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix pointrcnn model in dev branch. Add a mask for bbox after decode to avoid get inf in bbox.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 49.57% // Head: 49.59% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (9e2ccbd) compared to base (7358646).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1874      +/-   ##
==========================================
+ Coverage   49.57%   49.59%   +0.02%     
==========================================
  Files         227      227              
  Lines       19707    19708       +1     
  Branches     3207     3207              
==========================================
+ Hits         9769     9775       +6     
+ Misses       9351     9346       -5     
  Partials      587      587              
Flag Coverage Δ
unittests 49.59% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet3d/models/dense_heads/point_rpn_head.py 26.62% <0.00%> (-0.18%) ⬇️
mmdet3d/datasets/pipelines/transforms_3d.py 88.25% <0.00%> (+0.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Tai-Wang Tai-Wang merged commit cfd3a3a into open-mmlab:dev Sep 30, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants