[Fix] Fix piece_expected_num in IoUNegPiecewiseSampler in dev branch
#2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 49.96% // Head: 49.96% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #2018 +/- ##
=======================================
Coverage 49.96% 49.96%
=======================================
Files 228 228
Lines 19915 19916 +1
Branches 3187 3187
=======================================
+ Hits 9951 9952 +1
Misses 9374 9374
Partials 590 590
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
JingweiZhang12
approved these changes
Nov 15, 2022
|
LGTM. I also fix the lint. |
JingweiZhang12
requested review from
Tai-Wang and
ZwwWayne
and removed request for
Tai-Wang
JingweiZhang12
changed the title
piece_expected_num in IoUNegPiecewiseSampler in dev branch
JingweiZhang12
requested review from
Tai-Wang
and removed request for
ZwwWayne
|
LGTM |
Tai-Wang
approved these changes
Nov 23, 2022
ZwwWayne
pushed a commit
to ZwwWayne/mmdetection3d
that referenced
this pull request
Dec 16, 2022
open-mmlab#2018) * Update iou_neg_piecewise_sampler.py * fix lint Co-authored-by: JingweiZhang12 <zjw18@mails.tsinghua.edu.cn>
ZwwWayne
pushed a commit
that referenced
this pull request
Dec 16, 2022
#2018) * Update iou_neg_piecewise_sampler.py * fix lint Co-authored-by: JingweiZhang12 <zjw18@mails.tsinghua.edu.cn>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Fix #2004
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist